KVM: VMX: Isolate pure loads from atomic XCHG when processing PIR
authorSean Christopherson <seanjc@google.com>
Tue, 1 Apr 2025 16:34:45 +0000 (09:34 -0700)
committerSean Christopherson <seanjc@google.com>
Thu, 24 Apr 2025 18:19:40 +0000 (11:19 -0700)
commitb41f8638b9d30fbe045b4ef83ff4136c56a57397
treeae3a5c8e389d4f02f795e2eeb34266dbe1abc40e
parent06b4d0ea226c295e85a9daa6aed0ae9fa3ff8a94
KVM: VMX: Isolate pure loads from atomic XCHG when processing PIR

Rework KVM's processing of the PIR to use the same algorithm as posted
MSIs, i.e. to do READ(x4) => XCHG(x4) instead of (READ+XCHG)(x4).  Given
KVM's long-standing, sub-optimal use of 32-bit accesses to the PIR, it's
safe to say far more thought and investigation was put into handling the
PIR for posted MSIs, i.e. there's no reason to assume KVM's existing
logic is meaningful, let alone superior.

Matching the processing done by posted MSIs will also allow deduplicating
the code between KVM and posted MSIs.

See the comment for handle_pending_pir() added by commit 1b03d82ba15e
("x86/irq: Install posted MSI notification handler") for details on
why isolating loads from XCHG is desirable.

Suggested-by: Jim Mattson <jmattson@google.com>
Link: https://lore.kernel.org/r/20250401163447.846608-7-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/lapic.c