ASoC: codecs: rt5682-sdw: simplify set_stream
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 24 Mar 2023 01:44:08 +0000 (09:44 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 29 Mar 2023 14:03:10 +0000 (15:03 +0100)
commitb3a2e00e20671091f7175f8f36b7f9c9ea2e77bb
tree419fb473a3bb6552fd10cbc2ffb353aec620b539
parentcf1d6a3ad07c982a09455bf8720dc75754909932
ASoC: codecs: rt5682-sdw: simplify set_stream

Using a dynamic allocation to store a single pointer is not very
efficient/useful.

Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.

And last the API requires the previous stream information to be
cleared when the argument is NULL.

Simplify the code to address all 3 problems.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-14-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5682-sdw.c