mm: expose abnormal new_pte during move_ptes
authorPu Lehui <pulehui@huawei.com>
Thu, 29 May 2025 15:56:48 +0000 (15:56 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 6 Jun 2025 04:55:41 +0000 (21:55 -0700)
commitb36b701bbcd9f7b24c0d98499c28895b55fdde81
treef0cbec1540729f53277b3cf8d3556ff6601a1941
parent2b12d06c37fd3a394376f42f026a7478d826ed63
mm: expose abnormal new_pte during move_ptes

When executing move_ptes, the new_pte must be NULL, otherwise it will be
overwritten by the old_pte, and cause the abnormal new_pte to be leaked.
In order to make this problem to be more explicit, let's add WARN_ON_ONCE
when new_pte is not NULL.

[akpm@linux-foundation.org: s/WARN_ON_ONCE/VM_WARN_ON_ONCE/]
Link: https://lkml.kernel.org/r/20250529155650.4017699-3-pulehui@huaweicloud.com
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Pu Lehui <pulehui@huawei.com>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Jann Horn <jannh@google.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mremap.c