lsm: fix default return value for inode_getsecctx
authorOndrej Mosnacek <omosnace@redhat.com>
Tue, 31 Oct 2023 12:32:07 +0000 (13:32 +0100)
committerPaul Moore <paul@paul-moore.com>
Wed, 8 Nov 2023 20:39:42 +0000 (15:39 -0500)
commitb36995b8609a5a8fe5cf259a1ee768fcaed919f8
tree85eb5e04fd0a67f184ad34c125c61815e7b950c8
parent866d648059d5faf53f1cd960b43fe8365ad93ea7
lsm: fix default return value for inode_getsecctx

-EOPNOTSUPP is the return value that implements a "no-op" hook, not 0.

Without this fix having only the BPF LSM enabled (with no programs
attached) can cause uninitialized variable reads in
nfsd4_encode_fattr(), because the BPF hook returns 0 without touching
the 'ctxlen' variable and the corresponding 'contextlen' variable in
nfsd4_encode_fattr() remains uninitialized, yet being treated as valid
based on the 0 return value.

Cc: stable@vger.kernel.org
Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
Reported-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
include/linux/lsm_hook_defs.h