drm/vc4: txp: Switch to drmm_kzalloc
authorMaxime Ripard <maxime@cerno.tech>
Mon, 11 Jul 2022 17:39:21 +0000 (19:39 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 13 Jul 2022 08:46:11 +0000 (10:46 +0200)
commitb0da34c7970f6a5f156fd8036fbb83c999903628
tree33a99b5664930ce999f4e6a9877e627572f230c5
parent260ad78e9df95aa6154d85e7a9247aef28664854
drm/vc4: txp: Switch to drmm_kzalloc

Our internal structure that stores the DRM entities structure is allocated
through a device-managed kzalloc.

This means that this will eventually be freed whenever the device is
removed. In our case, the most likely source of removal is that the main
device is going to be unbound, and component_unbind_all() is being run.

However, it occurs while the DRM device is still registered, which will
create dangling pointers, eventually resulting in use-after-free.

Switch to a DRM-managed allocation to keep our structure until the DRM
driver doesn't need it anymore.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220711173939.1132294-52-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_txp.c