watchdog: armada_37xx_wdt: Convert to use device managed functions and other improvements
authorGuenter Roeck <linux@roeck-us.net>
Mon, 8 Apr 2019 19:38:25 +0000 (12:38 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:14 +0000 (21:02 +0200)
commitb09c153927c10abb70b01fa66753aec4d21ee70e
tree7de0d98a3a0350b250394ac46f60a3d96764ec4c
parentb07e228eee69601addba98b47b1a3850569e5013
watchdog: armada_37xx_wdt: Convert to use device managed functions and other improvements

Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.
Other improvements as listed below.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

- Drop assignments to otherwise unused variables
- Drop unnecessary braces around conditional return statements
- Drop empty remove function
- Use devm_add_action_or_reset() for calls to clk_disable_unprepare
- Use devm_watchdog_register_driver() to register watchdog device
- Replace shutdown function with call to watchdog_stop_on_reboot()

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/armada_37xx_wdt.c