USB: sisusbvga: Fix a potential UB casued by left shifting a negative value
authorChangming Liu <charley.ashbringer@gmail.com>
Sat, 11 Jul 2020 04:30:18 +0000 (00:30 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:29:24 +0000 (11:29 +0200)
commitb082d42f1c1733d057b859a26791176c200f36eb
tree62f3c88e70f24217a89c5eff443080277d42f090
parent7278a1b0a17fdc0f05379bdf055498d51998d61b
USB: sisusbvga: Fix a potential UB casued by left shifting a negative value

[ Upstream commit 2b53a19284f537168fb506f2f40d7fda40a01162 ]

The char buffer buf, receives data directly from user space,
so its content might be negative and its elements are left
shifted to form an unsigned integer.

Since left shifting a negative value is undefined behavior, thus
change the char to u8 to elimintate this UB.

Signed-off-by: Changming Liu <charley.ashbringer@gmail.com>
Link: https://lore.kernel.org/r/20200711043018.928-1-charley.ashbringer@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/misc/sisusbvga/sisusb.c