lib/rbtree: use '+' instead of '|' for setting color.
authorNoah Goldstein <goldstein.w.n@gmail.com>
Tue, 4 Apr 2023 22:13:51 +0000 (17:13 -0500)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 18 Apr 2023 23:39:33 +0000 (16:39 -0700)
commitb0687c1119b4e8c88a651b6e876b7eae28d076e3
tree82529e06903d712793f28d544a531f54f5711d6c
parent1be2edb25c72c3fe1bf955694c5521b035fcb276
lib/rbtree: use '+' instead of '|' for setting color.

This has a slight benefit for x86 and has no effect on other targets.

The benefit to x86 is it change the codegen for setting a node to block
from `mov %r0, %r1; or $RB_BLACK, %r1` to `lea RB_BLACK(%r0), %r1` which
saves an instructions.

In all other cases it just replace ALU with ALU (or -> and) which
perform the same on all machines I am aware of.

Total instructions in rbtree.o:
    Before  - 802
    After   - 782

so it saves about 20 `mov` instructions.

Link: https://lkml.kernel.org/r/20230404221350.3806566-1-goldstein.w.n@gmail.com
Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Michel Lespinasse <michel@lespinasse.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/rbtree_augmented.h
lib/rbtree.c