f2fs: compress: fix to avoid use-after-free on dic
authorChao Yu <chao@kernel.org>
Mon, 28 Aug 2023 14:04:15 +0000 (22:04 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 12 Sep 2023 20:49:33 +0000 (13:49 -0700)
commitb0327c84e91a0f4f0abced8cb83ec86a7083f086
tree709391d1dd3d0fc649d3bb2a5cffc1097c34b4fb
parentc5d3f9b7649abb20aa5ab3ebff9421a171eaeb22
f2fs: compress: fix to avoid use-after-free on dic

Call trace:
 __memcpy+0x128/0x250
 f2fs_read_multi_pages+0x940/0xf7c
 f2fs_mpage_readpages+0x5a8/0x624
 f2fs_readahead+0x5c/0x110
 page_cache_ra_unbounded+0x1b8/0x590
 do_sync_mmap_readahead+0x1dc/0x2e4
 filemap_fault+0x254/0xa8c
 f2fs_filemap_fault+0x2c/0x104
 __do_fault+0x7c/0x238
 do_handle_mm_fault+0x11bc/0x2d14
 do_mem_abort+0x3a8/0x1004
 el0_da+0x3c/0xa0
 el0t_64_sync_handler+0xc4/0xec
 el0t_64_sync+0x1b4/0x1b8

In f2fs_read_multi_pages(), once f2fs_decompress_cluster() was called if
we hit cached page in compress_inode's cache, dic may be released, it needs
break the loop rather than continuing it, in order to avoid accessing
invalid dic pointer.

Fixes: 6ce19aff0b8c ("f2fs: compress: add compress_inode to cache compressed blocks")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/data.c