vdso: Improve cmd_vdso_check to check all dynamic relocations
authorFangrui Song <maskray@google.com>
Fri, 10 Mar 2023 19:07:50 +0000 (19:07 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 21 Mar 2023 20:15:34 +0000 (21:15 +0100)
commitaff69273af61f5d1c8fb401d6f19148d11629b41
treeb45cbe16a6ef5789850b4fd5676dbf59682dc328
parente8d018dd0257f744ca50a729e3d042cf2ec9da65
vdso: Improve cmd_vdso_check to check all dynamic relocations

The actual intention is that no dynamic relocation exists in the VDSO. For
this the VDSO build validates that the resulting .so file does not have any
relocations which are specified via $(ARCH_REL_TYPE_ABS) per architecture,
which is fragile as e.g. ARM64 lacks an entry for R_AARCH64_RELATIVE. Aside
of that ARCH_REL_TYPE_ABS is a misnomer as it checks for relative
relocations too.

However, some GNU ld ports produce unneeded R_*_NONE relocation entries. If
a port fails to determine the exact .rel[a].dyn size, the trailing zeros
become R_*_NONE relocations. E.g. ld's powerpc port recently fixed
https://sourceware.org/bugzilla/show_bug.cgi?id=29540). R_*_NONE are
generally a no-op in the dynamic loaders. So just ignore them.

Remove the ARCH_REL_TYPE_ABS defines and just validate that the resulting
.so file does not contain any R_* relocation entries except R_*_NONE.

Signed-off-by: Fangrui Song <maskray@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com> # for aarch64
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com> # for vDSO, aarch64
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Link: https://lore.kernel.org/r/20230310190750.3323802-1-maskray@google.com
12 files changed:
arch/arm/vdso/Makefile
arch/arm64/kernel/vdso/Makefile
arch/arm64/kernel/vdso32/Makefile
arch/csky/kernel/vdso/Makefile
arch/loongarch/vdso/Makefile
arch/mips/vdso/Makefile
arch/powerpc/kernel/vdso/Makefile
arch/riscv/kernel/vdso/Makefile
arch/s390/kernel/vdso32/Makefile
arch/s390/kernel/vdso64/Makefile
arch/x86/entry/vdso/Makefile
lib/vdso/Makefile