net: bridge: Fix missing return assignment from br_vlan_replay_one call
authorColin Ian King <colin.king@canonical.com>
Wed, 24 Mar 2021 15:09:50 +0000 (15:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Mar 2021 19:45:48 +0000 (12:45 -0700)
commitad248f7761eb9a3ff9ba2a8c93b548600185a938
tree126ec4542e099e0f86bdc417e3ce80ecbb3c5f42
parentbb11d9ac9d465cd18d3dc3ac09bb4b9ab9ddf3bd
net: bridge: Fix missing return assignment from br_vlan_replay_one call

The call to br_vlan_replay_one is returning an error return value but
this is not being assigned to err and the following check on err is
currently always false because err was initialized to zero. Fix this
by assigning err.

Addresses-Coverity: ("'Constant' variable guards dead code")
Fixes: 22f67cdfae6a ("net: bridge: add helper to replay VLANs installed on port")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_vlan.c