vsock: Do not allow binding to VMADDR_PORT_ANY
authorBudimir Markovic <markovicbudimir@gmail.com>
Thu, 7 Aug 2025 04:18:11 +0000 (04:18 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 Aug 2025 19:55:00 +0000 (12:55 -0700)
commitaba0c94f61ec05315fa7815d21aefa4c87f6a9f4
tree76de9ac72880d01c4f0746117a73157a216705ab
parent5f1d1d14db7dabce9c815e7d7cd351f8d58b8585
vsock: Do not allow binding to VMADDR_PORT_ANY

It is possible for a vsock to autobind to VMADDR_PORT_ANY. This can
cause a use-after-free when a connection is made to the bound socket.
The socket returned by accept() also has port VMADDR_PORT_ANY but is not
on the list of unbound sockets. Binding it will result in an extra
refcount decrement similar to the one fixed in fcdd2242c023 (vsock: Keep
the binding until socket destruction).

Modify the check in __vsock_bind_connectible() to also prevent binding
to VMADDR_PORT_ANY.

Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
Reported-by: Budimir Markovic <markovicbudimir@gmail.com>
Signed-off-by: Budimir Markovic <markovicbudimir@gmail.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20250807041811.678-1-markovicbudimir@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/vmw_vsock/af_vsock.c