fs/smb: Fix inconsistent refcnt update
authorShuhao Fu <sfual@cse.ust.hk>
Wed, 27 Aug 2025 18:24:19 +0000 (02:24 +0800)
committerSteve French <stfrench@microsoft.com>
Wed, 27 Aug 2025 19:59:06 +0000 (14:59 -0500)
commitab529e6ca1f67bcf31f3ea80c72bffde2e9e053e
tree9ec513c082fbbee48a0e6e242a12594ce2cf0692
parent0e08fa789d39aa01923e3ba144bd808291895c3c
fs/smb: Fix inconsistent refcnt update

A possible inconsistent update of refcount was identified in `smb2_compound_op`.
Such inconsistent update could lead to possible resource leaks.

Why it is a possible bug:
1. In the comment section of the function, it clearly states that the
reference to `cfile` should be dropped after calling this function.
2. Every control flow path would check and drop the reference to
`cfile`, except the patched one.
3. Existing callers would not handle refcount update of `cfile` if
-ENOMEM is returned.

To fix the bug, an extra goto label "out" is added, to make sure that the
cleanup logic would always be respected. As the problem is caused by the
allocation failure of `vars`, the cleanup logic between label "finished"
and "out" can be safely ignored. According to the definition of function
`is_replayable_error`, the error code of "-ENOMEM" is not recoverable.
Therefore, the replay logic also gets ignored.

Signed-off-by: Shuhao Fu <sfual@cse.ust.hk>
Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Cc: stable@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2inode.c