mmc: sdhci: Do not lock spinlock around mmc_gpio_get_ro()
authorAdrian Hunter <adrian.hunter@intel.com>
Fri, 14 Jun 2024 08:00:50 +0000 (11:00 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 20 Jun 2024 14:42:30 +0000 (16:42 +0200)
commitab069ce125965a5e282f7b53b86aee76ab32975c
tree811f2f847073b16d2b1fed0ba7e3041d9825d0ec
parentfbd64f902b93fe9658b855b9892ae59ef6ea22b9
mmc: sdhci: Do not lock spinlock around mmc_gpio_get_ro()

sdhci_check_ro() can call mmc_gpio_get_ro() while holding the sdhci
host->lock spinlock. That would be a problem if the GPIO access done by
mmc_gpio_get_ro() needed to sleep.

However, host->lock is not needed anyway. The mmc core ensures that host
operations do not race with each other, and asynchronous callbacks like the
interrupt handler, software timeouts, completion work etc, cannot affect
sdhci_check_ro().

So remove the locking.

Fixes: 6d5cd068ee59 ("mmc: sdhci: use WP GPIO in sdhci_check_ro()")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240614080051.4005-3-adrian.hunter@intel.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci.c