i2c: mv64xxx: Fix check for missing clock after adding RPM
authorSamuel Holland <samuel@sholland.org>
Mon, 8 Feb 2021 06:19:22 +0000 (00:19 -0600)
committerWolfram Sang <wsa@kernel.org>
Tue, 9 Feb 2021 10:41:59 +0000 (11:41 +0100)
commitaab0b4fe1b757fb40466e506d296b81b03cc1594
tree1c5dcfe9e711fa27494e680a32e9b460d03505f2
parenta39bd92e92b96d05d676fb5c9493cf1c911d2a0a
i2c: mv64xxx: Fix check for missing clock after adding RPM

In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
pointers to optional clocks were replaced by NULL to simplify the resume
callback implementation. However, that commit missed that the IS_ERR
check in mv64xxx_of_config should be replaced with a NULL check. As a
result, the check always passes, even for an invalid device tree.

Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mv64xxx.c