gpio: gpiolib: Allow GPIO IRQs to lazy disable
authorMaulik Shah <mkshah@codeaurora.org>
Sat, 23 May 2020 17:11:10 +0000 (22:41 +0530)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 28 May 2020 21:32:38 +0000 (23:32 +0200)
commita8173820f441ab3e2a45c4bb66b70da9a57a349e
tree7cfd0d6fa9577e1622239427c5c2149ae77288d4
parenta34d5e56315007519f6c748e3ca0cb367264bbda
gpio: gpiolib: Allow GPIO IRQs to lazy disable

With 'commit 461c1a7d4733 ("gpiolib: override irq_enable/disable")' gpiolib
overrides irqchip's irq_enable and irq_disable callbacks. If irq_disable
callback is implemented then genirq takes unlazy path to disable irq.

Underlying irqchip may not want to implement irq_disable callback to lazy
disable irq when client drivers invokes disable_irq(). By overriding
irq_disable callback, gpiolib ends up always unlazy disabling IRQ.

Allow gpiolib to lazy disable IRQs by overriding irq_disable callback only
if irqchip implemented irq_disable. In cases where irq_disable is not
implemented irq_mask is overridden. Similarly override irq_enable callback
only if irqchip implemented irq_enable otherwise irq_unmask is overridden.

Fixes: 461c1a7d4733 ("gpiolib: override irq_enable/disable")
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Tested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Link: https://lore.kernel.org/r/1590253873-11556-2-git-send-email-mkshah@codeaurora.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c
include/linux/gpio/driver.h