arm64/crc32: Implement 4-way interleave using PMULL
authorArd Biesheuvel <ardb@kernel.org>
Fri, 18 Oct 2024 07:53:51 +0000 (09:53 +0200)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 22 Oct 2024 10:54:43 +0000 (11:54 +0100)
commita6478d69cf56d5deb4c28a6486376d9c7895abec
tree67c13a9b2a78e82813d236c8205e2ebae12d8572
parentb98b23e19492f4009070761c53b755f623f60e49
arm64/crc32: Implement 4-way interleave using PMULL

Now that kernel mode NEON no longer disables preemption, using FP/SIMD
in library code which is not obviously part of the crypto subsystem is
no longer problematic, as it will no longer incur unexpected latencies.

So accelerate the CRC-32 library code on arm64 to use a 4-way
interleave, using PMULL instructions to implement the folding.

On Apple M2, this results in a speedup of 2 - 2.8x when using input
sizes of 1k - 8k. For smaller sizes, the overhead of preserving and
restoring the FP/SIMD register file may not be worth it, so 1k is used
as a threshold for choosing this code path.

The coefficient tables were generated using code provided by Eric. [0]

[0] https://github.com/ebiggers/libdeflate/blob/master/scripts/gen_crc32_multipliers.c

Cc: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Link: https://lore.kernel.org/r/20241018075347.2821102-8-ardb+git@google.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/lib/crc32-glue.c
arch/arm64/lib/crc32.S