perf subcmd: avoid crash in exclude_cmds when excludes is empty
authorhupu <hupu.gm@gmail.com>
Wed, 10 Sep 2025 08:16:55 +0000 (16:16 +0800)
committerNamhyung Kim <namhyung@kernel.org>
Sat, 13 Sep 2025 00:51:35 +0000 (17:51 -0700)
commita5edf3550f4260504b7e0ab3d40d13ffe924b773
treee1eef70cf334bb3d60b11238dd1d03cdc23cf911
parentca81e74dc34734078d34485d4aa123561ba75b15
perf subcmd: avoid crash in exclude_cmds when excludes is empty

When cross-compiling the perf tool for ARM64, `perf help` may crash
with the following assertion failure:

  help.c:122: exclude_cmds: Assertion `cmds->names[ci] == NULL' failed.

This happens when the perf binary is not named exactly "perf" or when
multiple "perf-*" binaries exist in the same directory. In such cases,
the `excludes` command list can be empty, which leads to the final
assertion in exclude_cmds() being triggered.

Add a simple guard at the beginning of exclude_cmds() to return early
if excludes->cnt is zero, preventing the crash.

Signed-off-by: hupu <hupu.gm@gmail.com>
Reported-by: Guilherme Amadio <amadio@gentoo.org>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20250909094953.106706-1-amadio@gentoo.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/lib/subcmd/help.c