Bluetooth: hci_event: shut up a false-positive warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 22 Nov 2023 22:17:44 +0000 (23:17 +0100)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 15 Dec 2023 16:51:08 +0000 (11:51 -0500)
commita5812c68d849505ea657f653446512b85887f813
tree72c63431763acbf515df7c3ae487742d077c7564
parent99e67d46e5ff3c7c901af6009edec72d3d363be8
Bluetooth: hci_event: shut up a false-positive warning

Turning on -Wstringop-overflow globally exposed a misleading compiler
warning in bluetooth:

net/bluetooth/hci_event.c: In function 'hci_cc_read_class_of_dev':
net/bluetooth/hci_event.c:524:9: error: 'memcpy' writing 3 bytes into a
region of size 0 overflows the destination [-Werror=stringop-overflow=]
  524 |         memcpy(hdev->dev_class, rp->dev_class, 3);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The problem here is the check for hdev being NULL in bt_dev_dbg() that
leads the compiler to conclude that hdev->dev_class might be an invalid
pointer access.

Add another explicit check for the same condition to make sure gcc sees
this cannot happen.

Fixes: a9de9248064b ("[Bluetooth] Switch from OGF+OCF to using only opcodes")
Fixes: 1b56c90018f0 ("Makefile: Enable -Wstringop-overflow globally")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/hci_event.c