netpoll: Use rcu_access_pointer() in netpoll_poll_lock
authorBreno Leitao <leitao@debian.org>
Mon, 18 Nov 2024 11:15:18 +0000 (03:15 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 03:01:39 +0000 (19:01 -0800)
commita57d5a72f8dec7db8a79d0016fb0a3bdecc82b56
tree8689e499621e0d7e495ef6ee3edb36dba7de1726
parentc69c5e10adb903ae2438d4f9c16eccf43d1fcbc1
netpoll: Use rcu_access_pointer() in netpoll_poll_lock

The ndev->npinfo pointer in netpoll_poll_lock() is RCU-protected but is
being accessed directly for a NULL check. While no RCU read lock is held
in this context, we should still use proper RCU primitives for
consistency and correctness.

Replace the direct NULL check with rcu_access_pointer(), which is the
appropriate primitive when only checking for NULL without dereferencing
the pointer. This function provides the necessary ordering guarantees
without requiring RCU read-side protection.

Fixes: bea3348eef27 ("[NET]: Make NAPI polling independent of struct net_device objects.")
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-2-a1888dcb4a02@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netpoll.h