net: wwan: iosm: Fix error handling path in ipc_pcie_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Sat, 8 Apr 2023 19:43:21 +0000 (12:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Apr 2023 09:45:32 +0000 (10:45 +0100)
commita56ef25619e079bd7d744636cf18d054d1e91982
tree3d2a7f9a47bbe246c0d2452d520891c9d68eb844
parent9744d2bf19762703704ecba885b7ac282c02eacf
net: wwan: iosm: Fix error handling path in ipc_pcie_probe()

Smatch reports:
drivers/net/wwan/iosm/iosm_ipc_pcie.c:298 ipc_pcie_probe()
warn: missing unwind goto?

When dma_set_mask fails it directly returns without disabling pci
device and freeing ipc_pcie. Fix this my calling a correct goto label

As dma_set_mask returns either 0 or -EIO, we can use a goto label, as
it finally returns -EIO.

Add a set_mask_fail goto label which stands consistent with other goto
labels in this function..

Fixes: 035e3befc191 ("net: wwan: iosm: fix driver not working with INTEL_IOMMU disabled")
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wwan/iosm/iosm_ipc_pcie.c