RDMA/srp: Fix error handling in srp_add_port
authorMa Ke <make_ruc2021@163.com>
Tue, 17 Dec 2024 07:55:38 +0000 (15:55 +0800)
committerLeon Romanovsky <leon@kernel.org>
Thu, 19 Dec 2024 11:50:36 +0000 (06:50 -0500)
commita3cbf68c69611188cd304229e346bffdabfd4277
tree442ee9b2bef7b7a16740d05cc61c3145a5ada347
parentdb03b70969aab4ef111a3369cfd90ea4da3a6aa0
RDMA/srp: Fix error handling in srp_add_port

As comment of device_add() says, if device_add() succeeds, you should
call device_del() when you want to get rid of it. If device_add() has
not succeeded, use only put_device() to drop the reference count.

Add a put_device() call before returning from the function to decrement
reference count for cleanup.

Found by code review.

Fixes: c8e4c2397655 ("RDMA/srp: Rework the srp_add_port() error path")
Signed-off-by: Ma Ke <make_ruc2021@163.com>
Link: https://patch.msgid.link/20241217075538.2909996-1-make_ruc2021@163.com
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/ulp/srp/ib_srp.c