igc: return an error if the mac type is unknown in igc_ptp_systim_to_hwtstamp()
authorTom Rix <trix@redhat.com>
Tue, 31 Jan 2023 21:54:37 +0000 (13:54 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 2 Feb 2023 05:19:57 +0000 (21:19 -0800)
commita2df8463e15c10a8a882090f3d7a760fdb7b189d
tree64be5470a0b9288025a26248559ba44eabfd78fb
parent9c6b9cbafdc010b38f4077c8252654381eb46028
igc: return an error if the mac type is unknown in igc_ptp_systim_to_hwtstamp()

clang static analysis reports
drivers/net/ethernet/intel/igc/igc_ptp.c:673:3: warning: The left operand of
  '+' is a garbage value [core.UndefinedBinaryOperatorResult]
   ktime_add_ns(shhwtstamps.hwtstamp, adjust);
   ^            ~~~~~~~~~~~~~~~~~~~~

igc_ptp_systim_to_hwtstamp() silently returns without setting the hwtstamp
if the mac type is unknown.  This should be treated as an error.

Fixes: 81b055205e8b ("igc: Add support for RX timestamping")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20230131215437.1528994-1-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/igc/igc_ptp.c