net: bridge: vlan: fix single net device option dumping
authorNikolay Aleksandrov <nikolay@nvidia.com>
Wed, 26 Jan 2022 13:10:25 +0000 (15:10 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Feb 2022 16:25:47 +0000 (17:25 +0100)
commit9ffc94a81b0f2b7db78a630b5ae1032a551619d6
tree83f3ecbd11140ff96bc4c0e2c6ded33dc3bde2c2
parent869f1704f1c29debabde2fa2a12c30f90b81f86b
net: bridge: vlan: fix single net device option dumping

[ Upstream commit dcb2c5c6ca9b9177f04abaf76e5a983d177c9414 ]

When dumping vlan options for a single net device we send the same
entries infinitely because user-space expects a 0 return at the end but
we keep returning skb->len and restarting the dump on retry. Fix it by
returning the value from br_vlan_dump_dev() if it completed or there was
an error. The only case that must return skb->len is when the dump was
incomplete and needs to continue (-EMSGSIZE).

Reported-by: Benjamin Poirier <bpoirier@nvidia.com>
Fixes: 8dcea187088b ("net: bridge: vlan: add rtm definitions and dump support")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/bridge/br_vlan.c