mm/damon/core: prevent unnecessary overflow in damos_set_effective_quota()
authorQuanmin Yan <yanquanmin1@huawei.com>
Thu, 21 Aug 2025 12:55:55 +0000 (20:55 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 28 Aug 2025 05:45:43 +0000 (22:45 -0700)
commit9f68eabab9d9aaa764a8d234c4170119e6518102
treea0391b80733fdeb6741dff9bbf7791d7448fc481
parent6310c149e5dede74bb47110e0d7a38c78772c152
mm/damon/core: prevent unnecessary overflow in damos_set_effective_quota()

On 32-bit systems, the throughput calculation in
damos_set_effective_quota() is prone to unnecessary multiplication
overflow.  Using mult_frac() to fix it.

Andrew Paniakin also recently found and privately reported this issue, on
64 bit systems.  This can also happen on 64-bit systems, once the charged
size exceeds ~17 TiB.  On systems running for long time in production,
this issue can actually happen.

More specifically, when a DAMOS scheme having the time quota run for
longtime, throughput calculation can overflow and set esz too small.  As a
result, speed of the scheme get unexpectedly slow.

Link: https://lkml.kernel.org/r/20250821125555.3020951-1-yanquanmin1@huawei.com
Fixes: 1cd243030059 ("mm/damon/schemes: implement time quota")
Signed-off-by: Quanmin Yan <yanquanmin1@huawei.com>
Reported-by: Andrew Paniakin <apanyaki@amazon.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: ze zuo <zuoze1@huawei.com>
Cc: <stable@vger.kernel.org> [5.16+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c