net: stmmac: lpc18xx: use plat_dat->phy_interface
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 19 Jun 2025 09:47:26 +0000 (10:47 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Jun 2025 18:57:33 +0000 (11:57 -0700)
commit9f22c3ddb8cf0e49e9b1ad539d7f3bcb59381fad
treee98e52579a1fb6fa0e3bbc57ff2c19b7a241051e
parentd3b2afa987b5ffb4352a32e5063e5932e00c9872
net: stmmac: lpc18xx: use plat_dat->phy_interface

lpc18xx uses plat_dat->mac_interface, despite wanting to validate the
PHY interface. Checking the DT files (arch/arm/boot/dts/nxp/lpc/), none
of them specify mac-mode which means mac_interface and phy_interface
will be identical.

mac_interface is only used when there is some kind of MII converter
between the DesignWare MAC and PHY, and describes the interface mode
that the DW MAC needs to use, whereas phy_interface describes the
interface mode that the PHY uses.

Noting that lpc18xx only supports MII and RMII interface modes, switch
this glue driver to use plat_dat->phy_interface, and to mark that the
mac_interface is not used, explicitly set it to PHY_INTERFACE_MODE_NA.
The latter is safe as the only user of mac_interface for this platform
would be in stmmac_check_pcs_mode(), which only checks for RGMII or
SGMII.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Yanteng Si <siyanteng@cqsoftware.com.cn>
Link: https://patch.msgid.link/E1uSBri-004fL5-FI@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c