mm: kfence: pass a pointer to virt_to_page()
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 30 Jun 2022 08:41:22 +0000 (10:41 +0200)
committerakpm <akpm@linux-foundation.org>
Mon, 18 Jul 2022 00:14:36 +0000 (17:14 -0700)
commit9e7ee421ac1f8d7fe350d2dee87e31919e9cba84
tree1fbaec3735690824d137d0469757575dac01d25f
parent259ecb34e2cd73811e250fc9c8d1f07df7bb2d14
mm: kfence: pass a pointer to virt_to_page()

Functions that work on a pointer to virtual memory such as virt_to_pfn()
and users of that function such as virt_to_page() are supposed to pass a
pointer to virtual memory, ideally a (void *) or other pointer.  However
since many architectures implement virt_to_pfn() as a macro, this function
becomes polymorphic and accepts both a (unsigned long) and a (void *).

If we instead implement a proper virt_to_pfn(void *addr) function the
following happens (occurred on arch/arm):

mm/kfence/core.c:558:30: warning: passing argument 1
  of 'virt_to_pfn' makes pointer from integer without a
  cast [-Wint-conversion]

In one case we can refer to __kfence_pool directly (and that is a proper
(char *) pointer) and in the other call site we use an explicit cast.

Link: https://lkml.kernel.org/r/20220630084124.691207-4-linus.walleij@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kfence/core.c