KVM: x86: don't fall through case statements without annotations
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Sep 2024 22:23:33 +0000 (15:23 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 6 Sep 2024 22:23:33 +0000 (15:23 -0700)
commit9d4c304001cf44d24c643211a1673cf49ecaf287
tree6fd7a790525c4d6d8ff4b71e2e78f1d78b74ba2b
parent6b8ff511e412af4a367a8d3d4f323715a9357aa0
KVM: x86: don't fall through case statements without annotations

clang warns on this because it has an unannotated fall-through between
cases:

   arch/x86/kvm/x86.c:4819:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]

and while we could annotate it as a fallthrough, the proper fix is to
just add the break for this case, instead of falling through to the
default case and the break there.

gcc also has that warning, but it looks like gcc only warns for the
cases where they fall through to "real code", rather than to just a
break.  Odd.

Fixes: d30d9ee94cc0 ("KVM: x86: Only advertise KVM_CAP_READONLY_MEM when supported by VM")
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Tom Dohrmann <erbse.13@gmx.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/kvm/x86.c