powerpc/ptrace: Split gpr32_set_common
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Thu, 22 Jun 2023 10:01:23 +0000 (12:01 +0200)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 16 Aug 2023 13:54:50 +0000 (23:54 +1000)
commit9a32584bc108c8fe4d02fa33b16caf686e4a788a
treeb25d4a65b8d02ea9a3db52f1991acafb5c0f2e57
parent0e216fa576e1cdea3913fe82b7283fdfb58c5c07
powerpc/ptrace: Split gpr32_set_common

objtool reports the following warning:

  arch/powerpc/kernel/ptrace/ptrace-view.o: warning: objtool:
    gpr32_set_common+0x23c (.text+0x860): redundant UACCESS disable

gpr32_set_common() conditionally opens and closes UACCESS based on
whether kbuf pointer is NULL or not. This is wackelig.

Split gpr32_set_common() in two fonctions, one for user one for
kernel.

Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
[mpe: Fix oops in gpr32_set_common_user() due to NULL kbuf]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/b8d6ae4483fcfd17524e79d803c969694a85cc02.1687428075.git.christophe.leroy@csgroup.eu
arch/powerpc/kernel/ptrace/ptrace-view.c