net: sched: Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 10 Jul 2023 03:07:11 +0000 (03:07 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Jul 2023 07:23:53 +0000 (08:23 +0100)
commit989b52cdc84955c2a35bc18f53e3a83edfa6f404
tree1e09f018452e6b59d89ec076c39b8f6b3fdddc72
parent87355b7c3da9bfd81935caba0ab763355147f7b0
net: sched: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

Direct replacement is safe here since return value of -errno
is used to check for truncation instead of sizeof(dest).

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_api.c