iio: dac: ad5624r: Fix incorrect handling of an optional regulator.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 27 Jun 2021 16:32:37 +0000 (17:32 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 19 Jul 2021 08:51:58 +0000 (09:51 +0100)
commit97683c851f9cdbd3ea55697cbe2dcb6af4287bbd
tree6cffe0c771cbed8819e37ddb2f2ab6252adc7487
parent790a352b6f125e0d22edc0ae479bb2f2ef930fe3
iio: dac: ad5624r: Fix incorrect handling of an optional regulator.

The naming of the regulator is problematic.  VCC is usually a supply
voltage whereas these devices have a separate VREF pin.

Secondly, the regulator core might have provided a stub regulator if
a real regulator wasn't provided. That would in turn have failed to
provide a voltage when queried. So reality was that there was no way
to use the internal reference.

In order to avoid breaking any dts out in the wild, make sure to fallback
to the original vcc naming if vref is not available.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reported-by: kernel test robot <lkp@intel.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210627163244.1090296-9-jic23@kernel.org
drivers/iio/dac/ad5624r_spi.c