iommu: Fix potential memory leak in iopf_queue_remove_device()
authorLu Baolu <baolu.lu@linux.intel.com>
Fri, 17 Jan 2025 05:58:00 +0000 (13:58 +0800)
committerJoerg Roedel <jroedel@suse.de>
Mon, 10 Feb 2025 13:49:30 +0000 (14:49 +0100)
commit9759ae2cee7cd42b95f1c48aa3749bd02b5ddb08
tree48f551a755df9b44410e18a776605408fc1924a9
parenta64dcfb451e254085a7daee5fe51bf22959d52d3
iommu: Fix potential memory leak in iopf_queue_remove_device()

The iopf_queue_remove_device() helper removes a device from the per-iommu
iopf queue when PRI is disabled on the device. It responds to all
outstanding iopf's with an IOMMU_PAGE_RESP_INVALID code and detaches the
device from the queue.

However, it fails to release the group structure that represents a group
of iopf's awaiting for a response after responding to the hardware. This
can cause a memory leak if iopf_queue_remove_device() is called with
pending iopf's.

Fix it by calling iopf_free_group() after the iopf group is responded.

Fixes: 199112327135 ("iommu: Track iopf group instead of last fault")
Cc: stable@vger.kernel.org
Suggested-by: Kevin Tian <kevin.tian@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20250117055800.782462-1-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/io-pgfault.c