net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Mon, 2 Sep 2024 16:36:10 +0000 (18:36 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 3 Sep 2024 22:28:57 +0000 (15:28 -0700)
commit9748229c90dc4974f56874a2a19e040cc86de67e
tree77290c7b091d95bd00a5aa043baef67be8914ce8
parentd2088ca85ebc38c3e8783442ba2c0f3e5100ac6d
net: alacritech: Partially revert "net: alacritech: Switch to use dev_err_probe()"

This reverts commit bf4d87f884fe8a4b6b61fe4d0e05f293d08df61c because it
introduced dev_err_probe() in non-probe path, which is not desired.

In general, calling dev_err_probe() after successful probe in case of
handling -EPROBE_DEFER error, will set deferred status on the device
already probed.  This is however not a problem here now, because
dev_err_probe() in affected places is used for handling errors from
request_firmware(), which does not return -EPROBE_DEFER.  Still usage of
dev_err_probe() in such case is not correct, because request_firmware()
could once return -EPROBE_DEFER.

Fixes: bf4d87f884fe ("net: alacritech: Switch to use dev_err_probe()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240902163610.17028-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/alacritech/slicoss.c