wifi: iwlwifi: mld: avoid panic on init failure
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Wed, 4 Jun 2025 03:13:19 +0000 (06:13 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Wed, 4 Jun 2025 16:07:21 +0000 (19:07 +0300)
commit960c7e6d388034d219dafffa6da0a5c2ccd5ff30
tree9ed3110cb97c1c489a57eb724b2b6469e1404157
parent264c844abb29530b3e16d255f1eb2ccb06316b1f
wifi: iwlwifi: mld: avoid panic on init failure

In case of an error during init, in_hw_restart will be set, but it will
never get cleared.
Instead, we will retry to init again, and then we will act like we are in a
restart when we are actually not.

This causes (among others) to a NULL pointer dereference when canceling
rx_omi::finished_work, that was not even initialized, because we thought
that we are in hw_restart.

Set in_hw_restart to true only if the fw is running, then we know that
FW was loaded successfully and we are not going to the retry loop.

Fixes: 7391b2a4f7db ("wifi: iwlwifi: rework firmware error handling")
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250604061200.e0040e0a4b09.Iae469a0abe6bfa3c26d8a88c066bad75c2e8f121@changeid
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
drivers/net/wireless/intel/iwlwifi/mld/mld.c