regulator: core: Fix slab-out-of-bounds in regulator_unlock_recursive()
authorDmitry Osipenko <digetx@gmail.com>
Mon, 31 Aug 2020 20:43:35 +0000 (23:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Sep 2020 11:55:41 +0000 (13:55 +0200)
commit94abb06dc753434c0e1d230a269de05f441fc217
tree2106fc214f48646a543956dfbe6c2d06137be372
parente6724a64b9425c9dc45a4be993fb61ea4d0f2065
regulator: core: Fix slab-out-of-bounds in regulator_unlock_recursive()

commit 0a7416f94707c60b9f66b01c0a505b7e41375f3a upstream.

The recent commit 7d8196641ee1 ("regulator: Remove pointer table
overallocation") changed the size of coupled_rdevs and now KASAN is able
to detect slab-out-of-bounds problem in regulator_unlock_recursive(),
which is a legit problem caused by a typo in the code. The recursive
unlock function uses n_coupled value of a parent regulator for unlocking
supply regulator, while supply's n_coupled should be used. In practice
problem may only affect platforms that use coupled regulators.

Cc: stable@vger.kernel.org # 5.0+
Fixes: f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Link: https://lore.kernel.org/r/20200831204335.19489-1-digetx@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/regulator/core.c