net/ncsi: check for error return from call to nla_put_u32
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Wed, 29 Dec 2021 03:21:18 +0000 (11:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jan 2022 11:40:32 +0000 (12:40 +0100)
commit920932b20e0c33cb095e88dec16acd0d14986f50
tree674ca7ddbf3cb7c0b51fecf737b1427e1b62a643
parent610af55f9fbead4bd3d5636fa048d1e981a4a90f
net/ncsi: check for error return from call to nla_put_u32

[ Upstream commit 92a34ab169f9eefe29cd420ce96b0a0a2a1da853 ]

As we can see from the comment of the nla_put() that it could return
-EMSGSIZE if the tailroom of the skb is insufficient.
Therefore, it should be better to check the return value of the
nla_put_u32 and return the error code if error accurs.
Also, there are many other functions have the same problem, and if this
patch is correct, I will commit a new version to fix all.

Fixes: 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20211229032118.1706294-1-jiasheng@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ncsi/ncsi-netlink.c