random: do not xor RDRAND when writing into /dev/random
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 8 Feb 2022 12:00:11 +0000 (13:00 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 21 Feb 2022 15:48:06 +0000 (16:48 +0100)
commit91c2afca290ed3034841c8c8532e69ed9e16cf34
tree4af8f9ccf9fec175d117b7e3b6ef76fd1fd4b4ef
parenta02cf3d0dd77244fd5333ac48d78871de459ae6d
random: do not xor RDRAND when writing into /dev/random

Continuing the reasoning of "random: ensure early RDSEED goes through
mixer on init", we don't want RDRAND interacting with anything without
going through the mixer function, as a backdoored CPU could presumably
cancel out data during an xor, which it'd have a harder time doing when
being forced through a cryptographic hash function. There's actually no
need at all to be calling RDRAND in write_pool(), because before we
extract from the pool, we always do so with 32 bytes of RDSEED hashed in
at that stage. Xoring at this stage is needless and introduces a minor
liability.

Cc: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c