i2c: smbus: fix NULL function pointer dereference
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Fri, 26 Apr 2024 06:44:08 +0000 (08:44 +0200)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 10:57:57 +0000 (12:57 +0200)
commit91811a31b68d3765b3065f4bb6d7d6d84a7cfc9f
tree1c93b8e3eed29c8ee9d4ac0cef00f1d8a7f9f275
parent1d422e44e17c234cef262599e8e5dce6cd3ce28d
i2c: smbus: fix NULL function pointer dereference

Baruch reported an OOPS when using the designware controller as target
only. Target-only modes break the assumption of one transfer function
always being available. Fix this by always checking the pointer in
__i2c_transfer.

Reported-by: Baruch Siach <baruch@tkos.co.il>
Closes: https://lore.kernel.org/r/4269631780e5ba789cf1ae391eec1b959def7d99.1712761976.git.baruch@tkos.co.il
Fixes: 4b1acc43331d ("i2c: core changes for slave support")
[wsa: dropped the simplification in core-smbus to avoid theoretical regressions]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Baruch Siach <baruch@tkos.co.il>
drivers/i2c/i2c-core-base.c