drm/i915: Make sure all planes in use by the joiner have their crtc included
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 12 Feb 2025 16:43:21 +0000 (18:43 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Sat, 15 Feb 2025 07:27:39 +0000 (09:27 +0200)
commit91077d1deb5374eb8be00fb391710f00e751dc4b
treeef39a9f41641fc1503ff516bd6f23a080f8e5ec4
parent84a357bb0f7120e41620ee7aad3eeca233a4226c
drm/i915: Make sure all planes in use by the joiner have their crtc included

Any active plane needs to have its crtc included in the atomic
state. For planes enabled via uapi that is all handler in the core.
But when we use a plane for joiner the uapi code things the plane
is disabled and therefore doesn't have a crtc. So we need to pull
those in by hand. We do it first thing in
intel_joiner_add_affected_crtcs() so that any newly added crtc will
subsequently pull in all of its joined crtcs as well.

The symptoms from failing to do this are:
- duct tape in the form of commit 1d5b09f8daf8 ("drm/i915: Fix NULL
  ptr deref by checking new_crtc_state")
- the plane's hw state will get overwritten by the disabled
  uapi state if it can't find the uapi counterpart plane in
  the atomic state from where it should copy the correct state

Cc: stable@vger.kernel.org
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250212164330.16891-2-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_display.c