m68knommu: fix ucsimm sparse warnings
authorGreg Ungerer <gerg@linux-m68k.org>
Mon, 17 Jan 2022 07:53:51 +0000 (17:53 +1000)
committerGreg Ungerer <gerg@linux-m68k.org>
Sun, 13 Feb 2022 23:34:49 +0000 (09:34 +1000)
commit90ba8ee4c472e3de87954ac32a6348b1eff9df4c
tree1f1e8ef9e05079cfa414ea85ebd79048418263c8
parent4798b97f7a2d0648cf22a1cc76dc3dd61c6199ff
m68knommu: fix ucsimm sparse warnings

Sparse reports the following warnings:

  arch/m68k/68000/ucsimm.c:19:15: sparse: sparse: symbol 'cs8900a_hwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:22:1: sparse: sparse: symbol 'getserialnum' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:23:1: sparse: sparse: symbol 'gethwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:24:1: sparse: sparse: symbol 'getbenv' was not declared. Should it be static?

'cs8900a_hwaddr' is not used anywhere else in the kernel, so it can be
removed.

All of 'getserialnum', 'gethwaddr' and 'getbenv' are only used in this
file, so they can all be made static. It turns out that these also cause
compiler warnings like this too:

  arch/m68k/68000/ucsimm.c:22:15: warning: no previous prototype for 'getserialnum' [-Wmissing-prototypes]

Also fixed by making them all static.

Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
arch/m68k/68000/ucsimm.c