ext4: fix infinite loop when replaying fast_commit
authorLuis Henriques (SUSE) <luis.henriques@linux.dev>
Wed, 15 May 2024 08:28:57 +0000 (09:28 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 27 Jun 2024 14:26:28 +0000 (10:26 -0400)
commit907c3fe532253a6ef4eb9c4d67efb71fab58c706
tree759a2dc96eacad8c28b34d54e8a44b9a6d817169
parentb07855348b305c234d9fabb7ab9b50fa9b3a7759
ext4: fix infinite loop when replaying fast_commit

When doing fast_commit replay an infinite loop may occur due to an
uninitialized extent_status struct.  ext4_ext_determine_insert_hole() does
not detect the replay and calls ext4_es_find_extent_range(), which will
return immediately without initializing the 'es' variable.

Because 'es' contains garbage, an integer overflow may happen causing an
infinite loop in this function, easily reproducible using fstest generic/039.

This commit fixes this issue by unconditionally initializing the structure
in function ext4_es_find_extent_range().

Thanks to Zhang Yi, for figuring out the real problem!

Fixes: 8016e29f4362 ("ext4: fast commit recovery path")
Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20240515082857.32730-1-luis.henriques@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/extents_status.c