drm/amdgpu: Fix double free in amdgpu_userq_fence_driver_alloc()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 12 Apr 2025 14:39:32 +0000 (17:39 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 21 Apr 2025 14:52:53 +0000 (10:52 -0400)
commit8ff7c78baeeab746432934f7de82d56706c00c50
tree4cf732f2763ba778072acb40099d07ca7c83aa65
parent987718c5598a3044ecca1b6f774900df12927ed5
drm/amdgpu: Fix double free in amdgpu_userq_fence_driver_alloc()

The goto frees "fence_drv" so this is a double free bug.  There is no
need to call amdgpu_seq64_free(adev, fence_drv->va) since the seq64
allocation failed so change the goto to goto free_fence_drv.  Also
propagate the error code from amdgpu_seq64_alloc() instead of hard coding
it to -ENOMEM.

Fixes: e7cf21fbb277 ("drm/amdgpu: Few optimization and fixes for userq fence driver")
Reviewed-by: Arvind Yadav <arvind.yadav@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c