powerpc/book3s64/radix/tlb: Determine hugepage flush correctly
authorAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Wed, 13 May 2020 03:06:16 +0000 (08:36 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 20 May 2020 13:39:55 +0000 (23:39 +1000)
commit8f53f9c0f68ab2168f637494b9e24034899c1310
treec9c025fa9cbf7b13da4a92add0eb0be4ca938a61
parent787a2b682d18997e71efc2ae92ce158ca3e319e9
powerpc/book3s64/radix/tlb: Determine hugepage flush correctly

With a 64K page size flush with start and end:

  (start, end) = (721f680d0000721f680e0000)

results in:

  (hstart, hend) = (721f68200000721f68000000)

ie. hstart is above hend, which indicates no huge page flush is
needed.

However the current logic incorrectly sets hflush = true in this case,
because hstart != hend.

That causes us to call __tlbie_va_range() passing hstart/hend, to do a
huge page flush even though we don't need to. __tlbie_va_range() will
skip the actual tlbie operation for start > end. But it will still end
up calling fixup_tlbie_va_range() and doing the TLB fixups in there,
which is harmless but unnecessary work.

Reported-by: Bharata B Rao <bharata@linux.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
[mpe: Drop else case, hflush is already false, flesh out change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200513030616.152288-1-aneesh.kumar@linux.ibm.com
arch/powerpc/mm/book3s64/radix_tlb.c