fs/buffer: optimize discard_buffer()
authorDavidlohr Bueso <dave@stgolabs.net>
Thu, 15 May 2025 17:39:25 +0000 (10:39 -0700)
committerChristian Brauner <brauner@kernel.org>
Wed, 21 May 2025 07:34:29 +0000 (09:34 +0200)
commit8e184bf1cd7495c63242651de6190bb1678730b0
tree7da590135680a3117d938dfb6450d6577e85c45b
parentd11a24999605a054bef5e2ade7fedfaefce52388
fs/buffer: optimize discard_buffer()

While invalidating, the clearing of the bits in discard_buffer()
is done in one fully ordered CAS operation. In the past this was
done via individual clear_bit(), until e7470ee89f0 (fs: buffer:
do not use unnecessary atomic operations when discarding buffers).
This implies that there were never strong ordering requirements
outside of being serialized by the buffer lock.

As such relax the ordering for archs that can benefit. Further,
the implied ordering in buffer_unlock() makes current cmpxchg
implied barrier redundant due to release semantics. And while in
theory the unlock could be part of the bulk clearing, it is
best to leave it explicit, but without the double barriers.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://lore.kernel.org/20250515173925.147823-5-dave@stgolabs.net
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/buffer.c