wifi: brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()
authorWentao Liang <vulab@iscas.ac.cn>
Tue, 22 Apr 2025 04:22:02 +0000 (12:22 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 23 Apr 2025 12:59:04 +0000 (14:59 +0200)
commit8e089e7b585d95122c8122d732d1d5ef8f879396
tree4c8a64bccda277c1b9c2950aebeab99efbef31d7
parent0fb15ae3b0a9221be01715dac0335647c79f3362
wifi: brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()

The function brcmf_usb_dl_writeimage() calls the function
brcmf_usb_dl_cmd() but dose not check its return value. The
'state.state' and the 'state.bytes' are uninitialized if the
function brcmf_usb_dl_cmd() fails. It is dangerous to use
uninitialized variables in the conditions.

Add error handling for brcmf_usb_dl_cmd() to jump to error
handling path if the brcmf_usb_dl_cmd() fails and the
'state.state' and the 'state.bytes' are uninitialized.

Improve the error message to report more detailed error
information.

Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
Cc: stable@vger.kernel.org # v3.4+
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Link: https://patch.msgid.link/20250422042203.2259-1-vulab@iscas.ac.cn
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c