pidfd: improve uapi when task isn't found
authorChristian Brauner <brauner@kernel.org>
Thu, 3 Apr 2025 14:09:03 +0000 (16:09 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 7 Apr 2025 07:38:24 +0000 (09:38 +0200)
commit8cf4b738f6d84fdd8d7ff1e8d0e2298ded3e4153
treeaf530cf46f174b84cc5af25ebffcfe5522eda6f9
parent1b090949c9989a35c74aa2cd7fee6670b79019cd
pidfd: improve uapi when task isn't found

We currently report EINVAL whenever a struct pid has no tasked attached
anymore thereby conflating two concepts:

(1) The task has already been reaped.
(2) The caller requested a pidfd for a thread-group leader but the pid
    actually references a struct pid that isn't used as a thread-group
    leader.

This is causing issues for non-threaded workloads as in [1].

This patch tries to allow userspace to distinguish between (1) and (2).
This is racy of course but that shouldn't matter.

Link: https://github.com/systemd/systemd/pull/36982
Link: https://lore.kernel.org/r/20250403-work-pidfd-fixes-v1-3-a123b6ed6716@kernel.org
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
kernel/fork.c