mm/page_table_check: fix crash on ZONE_DEVICE
authorPeter Xu <peterx@redhat.com>
Wed, 5 Jun 2024 21:21:46 +0000 (17:21 -0400)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 15 Jun 2024 17:43:04 +0000 (10:43 -0700)
commit8bb592c2eca8fd2bc06db7d80b38da18da4a2f43
tree3ee30bea1274b725a6996d855c36163f66e7b0e7
parent8e5bd4eadd01ea0c47f3a1c798815849f813a700
mm/page_table_check: fix crash on ZONE_DEVICE

Not all pages may apply to pgtable check.  One example is ZONE_DEVICE
pages: they map PFNs directly, and they don't allocate page_ext at all
even if there's struct page around.  One may reference
devm_memremap_pages().

When both ZONE_DEVICE and page-table-check enabled, then try to map some
dax memories, one can trigger kernel bug constantly now when the kernel
was trying to inject some pfn maps on the dax device:

 kernel BUG at mm/page_table_check.c:55!

While it's pretty legal to use set_pxx_at() for ZONE_DEVICE pages for page
fault resolutions, skip all the checks if page_ext doesn't even exist in
pgtable checker, which applies to ZONE_DEVICE but maybe more.

Link: https://lkml.kernel.org/r/20240605212146.994486-1-peterx@redhat.com
Fixes: df4e817b7108 ("mm: page table check")
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alistair Popple <apopple@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/page_table_check.c