tracing: Do not free "head" on error path of filter_free_subsystem_filters()
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 10 Jun 2025 13:33:48 +0000 (09:33 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 10 Jun 2025 13:39:58 +0000 (09:39 -0400)
commit8a157d8a00e815cab4432653cb50c9cedbbb4931
treee282d839bf33bf2a74184f2f035ca344dbd6f345
parent19272b37aa4f83ca52bdf9c16d5d81bdd1354494
tracing: Do not free "head" on error path of filter_free_subsystem_filters()

The variable "head" is allocated and initialized as a list before
allocating the first "item" for the list. If the allocation of "item"
fails, it frees "head" and then jumps to the label "free_now" which will
process head and free it.

This will cause a UAF of "head", and it doesn't need to free it before
jumping to the "free_now" label as that code will free it.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20250610093348.33c5643a@gandalf.local.home
Fixes: a9d0aab5eb33 ("tracing: Fix regression of filter waiting a long time on RCU synchronization")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506070424.lCiNreTI-lkp@intel.com/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_filter.c