net: ngbe: fix memory leak in ngbe_probe() error path
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Sat, 12 Apr 2025 15:49:24 +0000 (21:19 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 15 Apr 2025 14:06:48 +0000 (16:06 +0200)
commit88fa80021b77732bc98f73fb69d69c7cc37b9f0d
tree2ed7375cf34512324d61d0b18cd5362c94db679b
parent65d91192aa66f05710cfddf6a14b5a25ee554dba
net: ngbe: fix memory leak in ngbe_probe() error path

When ngbe_sw_init() is called, memory is allocated for wx->rss_key
in wx_init_rss_key(). However, in ngbe_probe() function, the subsequent
error paths after ngbe_sw_init() don't free the rss_key. Fix that by
freeing it in error path along with wx->mac_table.

Also change the label to which execution jumps when ngbe_sw_init()
fails, because otherwise, it could lead to a double free for rss_key,
when the mac_table allocation fails in wx_sw_init().

Fixes: 02338c484ab6 ("net: ngbe: Initialize sw info and register netdev")
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://patch.msgid.link/20250412154927.25908-1-abdun.nihaal@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c