net: clear sk->sk_ino in sk_set_socket(sk, NULL)
authorEric Dumazet <edumazet@google.com>
Wed, 17 Sep 2025 13:53:37 +0000 (13:53 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 18 Sep 2025 14:47:17 +0000 (07:47 -0700)
commit87ebb628a5acb892eba41ef1d8989beb8f036034
tree85424bc4168c4b8ea0fce704ab4a1cceb5ef6314
parent3fbfe251cc9f6d391944282cdb9bcf0bd02e01f8
net: clear sk->sk_ino in sk_set_socket(sk, NULL)

Andrei Vagin reported that blamed commit broke CRIU.

Indeed, while we want to keep sk_uid unchanged when a socket
is cloned, we want to clear sk->sk_ino.

Otherwise, sock_diag might report multiple sockets sharing
the same inode number.

Move the clearing part from sock_orphan() to sk_set_socket(sk, NULL),
called both from sock_orphan() and sk_clone_lock().

Fixes: 5d6b58c932ec ("net: lockless sock_i_ino()")
Closes: https://lore.kernel.org/netdev/aMhX-VnXkYDpKd9V@google.com/
Closes: https://github.com/checkpoint-restore/criu/issues/2744
Reported-by: Andrei Vagin <avagin@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Andrei Vagin <avagin@google.com>
Link: https://patch.msgid.link/20250917135337.1736101-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/sock.h